put local channel behind user-specified channels, for remote priority #3038
Conversation
msarahan
force-pushed
the
allow_channels_ahead_of_local
branch
from
43bfeb1 to
d4b9c75
Compare
|
@msarahan, local priority should be the default here if people do not specify it, for those wanting a different order they should specify that explicitly I think. |
|
@mingwandroid local is still the default, because the channel list is empty without any -c argument. Prior to this PR, it was impossible to put anything before local. This PR only makes that possible. |
|
Doesn't this change mean it's no longer the case that people who use |
|
If you put it for every build, why don't you put it in condarc instead? There has to be a way for people to put channels ahead of local. You know I never want to break your workflow, but this is crippled right now. I can put this behind a flag, I guess, but having the split between CLI-specified things and condarc things makes sense to me. |
|
Anyway, not going to rush this into the next release, since it is contentious. |
|
@Bezier89 @mingwandroid I think this is better now. This will preserve existing behavior when local is not one of the manually specified channels. However, it should now be possible to put some other channel ahead of local by specifying both the other channel and local as arguments:
will put somechannel ahead of local, while
will not. |
conda_build/index.py
Outdated
| @@ -73,9 +71,18 @@ def get_build_index(subdir, bldpkgs_dir, output_folder=None, clear_cache=False, | |||
| log_context = partial(utils.LoggingContext, logging.CRITICAL + 1) | |||
| capture = utils.capture | |||
|
|
|||
| # priority: channels passed as args, local (can vary with either croot or output_folder), | |||
There was a problem hiding this comment.
You should update this comment to reflect the new change in behavior.
conda_build/index.py
Outdated
| if os.path.isdir(output_folder): | ||
| urls.insert(0, url_path(output_folder)) | ||
| if 'local' in urls: |
There was a problem hiding this comment.
This is fine as is, but this is 1 line shorter. Use whichever you prefer:
if 'local' not in urls:
urls.insert(0, 'local')
urls[urls.index('local')] = url_path(output_folder)
dc20fde to
0a13cb3
Compare
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
fixes #3036
Channels specified via --channel, -c on the CLI, or channel_urls (in the API) will take priority over locally built packages. Locally built packages still take priority over anything configured in condarc.